Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdl-dump: init at unstable-2020-02-05 #91714

Closed
wants to merge 1 commit into from
Closed

hdl-dump: init at unstable-2020-02-05 #91714

wants to merge 1 commit into from

Conversation

nilp0inter
Copy link
Contributor

@nilp0inter nilp0inter commented Jun 28, 2020 •
edited

Motivation for this change

I'd like to use the hdl_dump command to manage my PS2 game backup library from my NixOS box.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nilp0inter nilp0inter force-pushed the hdl-dump branch 2 times, most recently from 7452f7b to ddba0e8 Compare June 28, 2020 10:32
@nilp0inter nilp0inter force-pushed the hdl-dump branch 2 times, most recently from 3a0b1d5 to b46a298 Compare June 28, 2020 11:04
@nilp0inter nilp0inter changed the title hdl-dump: init at v0.9.2-43-gb0d7467 hdl-dump: init at 2020-02-05 Jun 28, 2020
@nilp0inter nilp0inter marked this pull request as ready for review June 28, 2020 11:32
IvarWithoutBones
IvarWithoutBones requested changes Jun 28, 2020
View reviewed changes
pkgs/tools/filesystems/hdl-dump/default.nix Outdated Show resolved Hide resolved
pkgs/tools/filesystems/hdl-dump/default.nix Outdated Show resolved Hide resolved
@nilp0inter nilp0inter changed the title hdl-dump: init at 2020-02-05 hdl-dump: init at unstable-2020-02-05 Jun 29, 2020
IvarWithoutBones
IvarWithoutBones approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@makefu makefu mentioned this pull request Oct 21, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

Replaced by #101243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nilp0inter @SuperSandro2000 @IvarWithoutBones