Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another Mediatek device. Before I received the previous one as a donation for porting purposes, I had intended this device to be the first Mediatek device.
Since the previous port went so well (really, if you forget about the brickiness), I decided to just do it.
I spent around a day's work on this. Not bad when you consider the following amusing fact.
Amusing fact: there are no custom ROMs for this phone. Additionally, there seems to be no TWRP builds with a fresh custom kernel, the only TWRP floating around uses the vendor's kernel build!
This makes Mobile NixOS the first and only alternative system for the Asus Zenfone Max Plus (M1) 馃帀
This device has only a basic feature set working, it boots, graphics work, inputs work, the older androidusb gadget works.
Thing worthy of note
fb-refresher
This changes the quirk name
qualcomm.msm-fb-refresher
tofb-refresher
, but NOT the package. Why? Because the package is a third party one, and it is its name!This SoC (or maybe the device?) seems to exhibit the same issue as Qualcomm devices, no page flips on write! So in the end it might have been a quirk that came from an early rush to implement the minimum required for Android? Who knows.
default-trigger
There is an implementation of
default-trigger
for this vintage of the mediatek LEDs driver. This may be useful for other older mediatek devices.In addition, this is an example (not necessarily a good one) of how to handle adding that feature if needed. The jist of it is to somehow read the device tree property off of the node, and set it to the classdev for the LED. If the driver is not completely broken, it should automatically work.