Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: amaranth-lang/amaranth
base: 303ea18cb605
Choose a base ref
...
head repository: amaranth-lang/amaranth
compare: 2606ee33ad54
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jun 28, 2020

  1. back.pysim: simplify. 

    Remove _EvalContext, which was a level of indirection serving almost
no purpose. (The only case where it would be useful is repeatedly
resetting a simulation that, each time it is reset, would create new
signals to communicate with between coroutine processes. In that case
the signal states would not be persisted in _SimulatorState, but
would be removed with the _EvalContext that is recreated each time
the simulation is reset. But this could be solved with a weak map
instead.)

This regresses simulator startup time by 10-15% for unknown reasons
but is necessary to align pysim and future cxxsim.
    @whitequark
    whitequark committed Jun 28, 2020
    Copy the full SHA
    2606ee3 View commit details
    Browse the repository at this point in the history