Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test this value of non-function callback interfaces #24372

Merged
merged 2 commits into from Jun 29, 2020
Merged

Test this value of non-function callback interfaces #24372

merged 2 commits into from Jun 29, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh commented Jun 28, 2020 •
edited

annevk
annevk approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should feel free to use let and const in older test files for new tests (or when refactoring), but var is acceptable of course.

Any browser bugs needing to be filed as a result?

@annevk
Copy link
Member

annevk commented Jun 29, 2020

Oh, it seems this needs rebasing. That's surprising.

@annevk
Copy link
Member

annevk commented Jun 29, 2020

Ah, due to your own work in #24370 😊

@wpt-pr-bot wpt-pr-bot requested review from arturjanc, dbaron, domenic, fantasai, foolip, frivoal, hemeryar and jgraham and removed request for jdm, zqzhang and deniak June 29, 2020 11:47
@shvaikalesh shvaikalesh force-pushed the callback-interface-object-this-value branch from 6187612 to 6196454 Compare June 29, 2020 12:01
@shvaikalesh
Copy link
Member Author

shvaikalesh commented Jun 29, 2020 •
edited

Thank you for review!
Rebase during GitHub outage caused a few extra labels.
WebKit bug: "acceptNode" method is called with incorrect this value.

@annevk annevk merged commit e3d418b into web-platform-tests:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@arturjanc arturjanc Awaiting requested review from arturjanc

@dbaron dbaron Awaiting requested review from dbaron

@domenic domenic Awaiting requested review from domenic

@fantasai fantasai Awaiting requested review from fantasai

@foolip foolip Awaiting requested review from foolip

@frivoal frivoal Awaiting requested review from frivoal

@hemeryar hemeryar Awaiting requested review from hemeryar

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

@kenchris kenchris Awaiting requested review from kenchris

@marcoscaceres marcoscaceres Awaiting requested review from marcoscaceres

@mgiuca mgiuca Awaiting requested review from mgiuca

@mikewest mikewest Awaiting requested review from mikewest

@ParisMeuleman ParisMeuleman Awaiting requested review from ParisMeuleman

@plinss plinss Awaiting requested review from plinss

Assignees

@zqzhang zqzhang

Labels
appmanifest css-backgrounds css-pseudo dom domxpath html interfaces ua-client-hints websockets wg-dom wg-webapps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shvaikalesh @annevk @zqzhang @wpt-pr-bot