Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.*: 2020.1.1/2/3 -> 2020.1.2/3/5 #91731

Merged
merged 1 commit into from Jun 29, 2020
Merged

jetbrains.*: 2020.1.1/2/3 -> 2020.1.2/3/5 #91731

merged 1 commit into from Jun 29, 2020

Conversation

ktor
Copy link
Member

@ktor ktor commented Jun 28, 2020

Motivation for this change

To get the latest JetBrains patches. Tested jetbrains.idea-ultimate. I was unable to update MPS version with update.pl script as sha256 key delivered by JetBrains was broken so I left it as it was before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ktor ktor requested a review from edwtjo as a code owner June 28, 2020 16:32
Ma27
Ma27 approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested phpstorm and idea-community.

@Ma27 Ma27 merged commit 6e46544 into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktor @Ma27