osm2pgsql: use libs from NixPkgs instead of vendored ones #91743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osm2pgsql "vendors" (i.e. contains in its own repo the source of) two libraries we have in NixPkgs and would build against and use these bundled versions by default:
These changes makes osm2pgsql compile against and use the respective libraries from NixPkgs instead. Further, I'm adding myself as an additional maintainer.
Motivation for this change
This avoids having to build libosmium and protozero as part of osm2pgsql when already-built store paths can be used instead.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)Result of
nixpkgs-review
11 package built:
- osm2pgsql