Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnix: add patch to fix flake8 failure #91708

Closed
wants to merge 1 commit into from
Closed

vulnix: add patch to fix flake8 failure #91708

wants to merge 1 commit into from

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Jun 28, 2020

Motivation for this change

https://hydra.nixos.org/build/123238104 (broken at head)

nix-community/vulnix#64 was already merged upstream, cherry-pick the fix.

cc @ckauhaus

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
Copy link
Contributor Author

delroth commented Jun 28, 2020

@ofborg build vulnix

@ofborg ofborg bot requested a review from ckauhaus June 28, 2020 08:37
@Ma27
Copy link
Member

Ma27 commented Jul 2, 2020

Is this obsolete as #92001 is now open?

@delroth delroth closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckauhaus ckauhaus Awaiting requested review from ckauhaus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@delroth @Ma27