python-jsonrpc-server: remove ujson version contraint #91707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since 141a029 the version constraint of the ujson dependency is changed via
sed
from "ujson<=1.35" to "ujson>=1.35" to allow for for a newer ujson version.This is bad for adaptability. If one decides to actually include a correct version of ujson (by using mach-nix for example), then the installation fails despite all dependencies are correct.
I think a better way to bypass upstream version containts is to just remove them.
@Mic92
Things done
Modify the sed command to replace
'ujson<=XXX'
with'ujson'
ujson
builds were failing when using nixpkgs-review, but I guess this has other reasons !?sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)