New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diffoscope: 148 -> 150 #91713
diffoscope: 148 -> 150 #91713
Conversation
A few more tests are failing for me:
|
Yes, see PR description :) |
Ahh right, sorry. |
Never mind, didn't notice that that goes through staging. |
Well, you can retarget this at staging (or staging-next after the change gets there). |
@ofborg build diffoscope |
The prerequisite is not in master yet – |
I dropped the custom patch and just bumped to 150 instead. |
(I can confirm diffoscope works again for me when I use staging with 8b9e7fd cherry-picked on top) |
Motivation for this change
Note that diffoscope is currently broken on master, and this bump only addresses part of the breakage. The other part is in #91711 which unfortunately needs to land in staging. This PR + #91711 together combine into a working (again) diffoscope on NixOS.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)