Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneDNN: add aarch64-linux to platforms #91752

Merged
merged 1 commit into from Jun 29, 2020
Merged

oneDNN: add aarch64-linux to platforms #91752

merged 1 commit into from Jun 29, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jun 29, 2020 •
edited

Motivation for this change

According to

https://github.com/oneapi-src/oneDNN/releases/tag/v1.5

AArch64 is now supported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from alexarice and bhipple June 29, 2020 07:47
@danieldk danieldk marked this pull request as ready for review June 29, 2020 08:01
@danieldk
Copy link
Contributor Author

That worked, so I marked this as ready to review.

bhipple
bhipple approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bhipple bhipple merged commit ca7d6eb into NixOS:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@alexarice alexarice Awaiting requested review from alexarice

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @bhipple