Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-jsonrpc-server: make version overridable #91723

Merged
merged 1 commit into from Nov 14, 2020
Merged

python-jsonrpc-server: make version overridable #91723

merged 1 commit into from Nov 14, 2020

Conversation

DavHau
Copy link
Member

@DavHau DavHau commented Jun 28, 2020

Motivation for this change

The way the version attribute was inserted into the postPatch script prevented it from being overridden via overrideAttrs or overridePythonAttrs. It would still use the original definition instead of the overridden one.

Things done

replace nix-based string substitution with bash-based string substitution

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Mic92 June 28, 2020 13:57
@DavHau
Copy link
Member Author

DavHau commented Jun 28, 2020

Can we merge this also into 20.03?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/367

@Mic92 Mic92 merged commit 1eac9a3 into NixOS:master Nov 14, 2020
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2020

We can backport it if you open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DavHau @nixos-discourse @Mic92