Fix #8162: Improve Error Message When Converting Town Owned Road #8247
Conversation
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.
|
Unused strings should be removed (in a separate commit, to keep changes clean) I'd consider a different (title) message for the commit as well - the abbreviations don't look great. "Fix #8162: Improve error message when converting town owned road", perhaps. |
TrevorShelton
changed the title
|
Alright, changed the title to that. |
|
Please just remove the old string from all the language files at once, instead of one file/one commit at a time. |
|
Oh, sorry, didn't come back to read this until I was done erasing it from all of the files. Is there a way to merge these or do I have to go back and use something else to do the erasure? (Sorry, fairly new to github commits.) |
|
Yes... Using the GitHub web interface isn't the greatest normally, and especially not when you have to edit multiple files. Get a local checkout, and edit the files there. https://guides.github.com/introduction/git-handbook/ |
LordAro
added
the
backport requested
glx22
added
backported
This changes the error when you attempt to convert a road owned by a town to another road, specifying that it's owned by the town rather than simply being incompatible. As the original poster of the issue pointed out, these seemed to be the only occurences of the incompatible road string, so now it's unused, but they would be left untouched in case of future use or since changing it to a different error would do the work of removing it then. If requested, it likely wouldn't be too difficult to remove the string entirely.