Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.lwt: 4.5.0 → 5.3.0 #91715

Merged
merged 3 commits into from Jul 5, 2020
Merged

ocamlPackages.lwt: 4.5.0 → 5.3.0 #91715

merged 3 commits into from Jul 5, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Jun 28, 2020

Motivation for this change

Fixes & improvements: https://github.com/ocsigen/lwt/releases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Jun 28, 2020

@GrahamcOfBorg build acgtk dune-release flow jackline reason stog

@vbgl vbgl merged commit cef53ab into NixOS:master Jul 5, 2020
@vbgl vbgl deleted the ocaml-lwt-5 branch July 5, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant