Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password: 1.0.0 -> 1.1.1 #91736

Merged
merged 1 commit into from Jul 3, 2020
Merged

Conversation

IvarWithoutBones
Copy link
Member

@IvarWithoutBones IvarWithoutBones commented Jun 28, 2020

Motivation for this change

Release notes are available here.

This also removes some duplicate code in the src fetching, what I've done is a bit cleaner IMO.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Jul 3, 2020

@GrahamcOfBorg build 1password

Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits and rename the commit message to use the attrpath _1password.

@ryantm
Copy link
Member

ryantm commented Jul 3, 2020

@GrahamcOfBorg build _1password

@ryantm ryantm merged commit 1981a9b into NixOS:master Jul 3, 2020
@IvarWithoutBones IvarWithoutBones deleted the 1password-update branch July 3, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants