Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtkcord: Init at 0.0.4 #91738

Closed
wants to merge 1 commit into from
Closed

gtkcord: Init at 0.0.4 #91738

wants to merge 1 commit into from

Conversation

skykanin
Copy link
Contributor

Motivation for this change

Add the gtkcord discord client

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit June 28, 2020 19:21
@pbogdan
Copy link
Member

pbogdan commented Jun 29, 2020

I'm not familiar with Go packaging but this looks good to me. I tested the application itself under GNOME on NixOS and so far everything is working well.

@skykanin skykanin requested a review from jtojnar June 30, 2020 14:18
@skykanin skykanin mentioned this pull request Jun 30, 2020
Open
@skykanin skykanin requested a review from jtojnar July 1, 2020 13:29
@skykanin skykanin force-pushed the gtkcord branch 2 times, most recently from c5dbc6a to a528c1e Compare July 1, 2020 20:05
@skykanin skykanin requested a review from jtojnar July 2, 2020 20:56
@doronbehar
Copy link
Contributor

@GrahamcOfBorg build gtkcord

@jtojnar jtojnar mentioned this pull request Sep 2, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91738 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • gtkcord

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91738 run on x86_64-linux 1

1 package failed to build:
  • gtkcord

Timed out after 600 seconds.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2020

Looks like the project has been abandoned, see #96941 (comment).

@skykanin
Copy link
Contributor Author

skykanin commented Dec 5, 2020

Closing PR because the gtkcord project has been abandoned

@skykanin skykanin closed this Dec 5, 2020
@skykanin skykanin deleted the gtkcord branch December 5, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbogdan pbogdan pbogdan left review comments

@doronbehar doronbehar doronbehar left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@iblech iblech iblech approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@skykanin @pbogdan @doronbehar @SuperSandro2000 @jtojnar @iblech