more output, default to print all #221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Aug 10, 2021
| @@ -1585,7 +1591,7 @@ template<class ElfFile> | |||
| static void patchElf2(ElfFile && elfFile, const FileContents & fileContents, std::string fileName) | |||
| { | |||
| if (printInterpreter) | |||
| printf("%s\n", elfFile.getInterpreter().c_str()); | |||
| printf("INTERPRETER: %s\n", elfFile.getInterpreter().c_str()); | |||
There was a problem hiding this comment.
Sorry. We cannot merge this as this would break our use in nixpkgs, which expects no prefix in many places.
|
In particular it breaks the following usecase: $ foo=$(patchelf --print-interpreter /run/current-system/sw/bin/ls)
$ echo $foo
/nix/store/cvr0kjg2q7z2wwhjblx6c73rv422k8cm-glibc-2.33-47/lib/ld-linux-x86-64.so.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if several -print-... options are given it is unclear which output refers to what as everything is just printed as
printf("<item>\n");. This puts an identified before the entry to clarify this.If a lib for removing was not found, no error/warning was given, this adds a success/failure message.
Also if no parameters are given it defaults to "print all", which is less to type and more convenient than a no-op as previously.
I did these changes just for me, if you like them accept, if not its fine :)