Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osmium-tools: run tests, install man pages and zsh completions #91735

Merged
merged 2 commits into from Jun 29, 2020
Merged

osmium-tools: run tests, install man pages and zsh completions #91735

merged 2 commits into from Jun 29, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

libosmium, osmium-tools: run tests. They are compiled anyway, so let's run them to detect regressions.

osmium-tools: it seems that upstream provides man pages and zsh completions, add them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk requested a review from das-g June 28, 2020 18:34
@das-g
Copy link
Member

das-g commented Jun 28, 2020

Result of nixpkgs-review pr 91735 1

5 packages built:
- libosmium
- osmium-tool
- python27Packages.pyosmium
- python37Packages.pyosmium
- python38Packages.pyosmium

@das-g
Copy link
Member

das-g commented Jun 28, 2020

To better see what semantically changed, I've singled out the formatting changes to a separate commit:
das-g/nixpkgs@osmium-reformat...das-g:osmium-tests

(No need to adopt that for the PR, unless you want to. This is just for review purposes.)

das-g
das-g approved these changes Jun 28, 2020
View reviewed changes
Copy link
Member

@das-g das-g left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 changes LGTM
👍 commits LGTM
✔️ everything that used to work seems to still work
✔️ man osmium now works 🎉
🤷 dunno how to test zsh completions without building a VM or rebuilding my system

Thank you for these improvements!
:shipit: Ship it!
(You'll have to merge the PR yourself, as I'm not a committer.)

@danieldk danieldk merged commit 3d4a02f into NixOS:master Jun 29, 2020
@danieldk danieldk deleted the osmium-tests branch June 29, 2020 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@das-g das-g das-g approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @das-g