Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfssl: 1.3.2 -> 1.4.1 #94123

Merged
merged 2 commits into from Jul 31, 2020
Merged

cfssl: 1.3.2 -> 1.4.1 #94123

merged 2 commits into from Jul 31, 2020

Conversation

blaggacao
Copy link
Contributor

@blaggacao blaggacao commented Jul 29, 2020 •
edited

  • Jep, cfssl server works (now) with embedded static files
  • All built commandos tested manually for --help

nix-review outputs in comment below.

image

@blaggacao blaggacao changed the title Da cfssl update cfssl: 1.3.2 -> 1.4.1 Jul 29, 2020
@blaggacao
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 29, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@blaggacao
Copy link
Contributor Author

Result of nixpkgs-review pr 94123 1

1 package built:
- cfssl

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/234

@ofborg ofborg bot requested review from mbrgm and kalbasit July 29, 2020 03:00
kalbasit
kalbasit requested changes Jul 29, 2020
View reviewed changes
pkgs/tools/security/cfssl/default.nix Outdated Show resolved Hide resolved
@kalbasit

This comment has been minimized.

Sign in to view
@blaggacao blaggacao requested a review from kalbasit July 29, 2020 15:37
kalbasit
kalbasit requested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@kalbasit kalbasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: the cfssl commit is missing a : between cfssl and the version.

pkgs/tools/misc/go.rice/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/go.rice/default.nix Show resolved Hide resolved
pkgs/tools/security/cfssl/default.nix Show resolved Hide resolved
@blaggacao
Copy link
Contributor Author

Thanks for the commit message catch. That would have been bad for parseability.

@blaggacao blaggacao requested a review from kalbasit July 29, 2020 19:14
@kalbasit
Copy link
Member

go-ryce: init at 1.0.0 you had it right earlier :(

Otherwise LGTM

@blaggacao
Copy link
Contributor Author

Oh, I assumed the original package name prevails "go.rice" - since the nix one is to avoid the ".". I'll change that tomorrow.

@Mic92
Copy link
Member

Mic92 commented Jul 30, 2020

/status awaiting_changes

@blaggacao
Copy link
Contributor Author

blaggacao commented Jul 31, 2020 •
edited

Addressed both comments from @Mic92 & @kalbasit .
/status needs_merger

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 31, 2020

The PR author cannot set the status to needs_merger. Please wait for an external review.

If you are not the PR author and you are reading this, please review the usage of this bot. You may be able to help. Please make an honest attempt to resolve all outstanding issues before setting to needs_merger.

@blaggacao blaggacao requested a review from Mic92 July 31, 2020 05:42
@blaggacao blaggacao requested a review from Mic92 July 31, 2020 05:47
@Mic92
Copy link
Member

Mic92 commented Jul 31, 2020

@GrahamcOfBorg build cfssl

@Mic92 Mic92 merged commit bccfcd3 into NixOS:master Jul 31, 2020
@blaggacao
Copy link
Contributor Author

Whoop Whoop! 🥳

@blaggacao blaggacao deleted the da-cfssl-update branch August 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrgm mbrgm Awaiting requested review from mbrgm

@kalbasit kalbasit Awaiting requested review from kalbasit

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blaggacao @nixos-discourse @kalbasit @Mic92