Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

istioctl: bundle charts #94164

Merged
merged 2 commits into from Aug 1, 2020
Merged

istioctl: bundle charts #94164

merged 2 commits into from Aug 1, 2020

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jul 29, 2020

Motivation for this change

Fixes #94163 (broken istioctl install)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions - Arch
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nightkr
Copy link
Member Author

nightkr commented Jul 29, 2020

/cc @veehaitch @danieldk

@ofborg ofborg bot requested a review from kalbasit July 29, 2020 10:00
@nightkr
Copy link
Member Author

nightkr commented Jul 29, 2020

Hm, looks like something's wrong, the bundled manifests refer to istiod from gcr.io/istio-testing/pilot:latest.rather than docker.io/istio/pilot:1.6.5 like the official builds...

@nightkr
istioctl: bundle release metadata
76856fc 
This is required for `istioctl version` to return the correct info, and for
`istioctl install` to default to the correct Docker images.
veehaitch
veehaitch approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@veehaitch veehaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Runs fine on macOS, I didn't try to install Istio though.

@danieldk danieldk merged commit ae75863 into NixOS:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veehaitch veehaitch veehaitch approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

istioctl doesn't include charts
3 participants
@nightkr @veehaitch @danieldk