Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lit: 0.9.0 -> 0.10.0 #94151

Merged
merged 1 commit into from Jul 29, 2020
Merged

lit: 0.9.0 -> 0.10.0 #94151

merged 1 commit into from Jul 29, 2020

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 29, 2020

Motivation for this change

lit from llvm 10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dasj19
dasj19 approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94151".

lit runs well.

Code looks good.

@Mic92 Mic92 merged commit 5ad1cda into NixOS:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @dasj19 @Mic92