Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jpylyzer: 1.18.0 -> 2.0.0 #94098

Merged
merged 1 commit into from Apr 13, 2021
Merged

pythonPackages.jpylyzer: 1.18.0 -> 2.0.0 #94098

merged 1 commit into from Apr 13, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jul 28, 2020 •
edited

Motivation for this change

Enabling tests at the same time.

This has a large list of reverse dependencies, but that is deceptive - it's merely that jpylyzer is a checkInput for openjpeg. So I haven't done the rebuild for this, but I'd argue that's ok because it's a purely transitive dependency.

Tested non-nixos linux x86_64, macos 10.14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor Author

risicle commented Jul 28, 2020

@GrahamcOfBorg build python38Packages.jpylyzer python27Packages.jpylyzer openjpeg

@jonringer
Copy link
Contributor

since this casuses 1000+ rebuilds, do you mind targeting staging?

@risicle
Copy link
Contributor Author

risicle commented Jul 28, 2020

Yup good call...

@risicle risicle changed the base branch from master to staging July 28, 2020 20:29
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@FRidh
Copy link
Member

FRidh commented Aug 15, 2020

@GrahamcOfBorg build openjpeg

@risicle
Copy link
Contributor Author

risicle commented Aug 30, 2020

Rebased against newer staging.

@FRidh FRidh added this to To do in Python batch upgrade Dec 2, 2020
@FRidh FRidh added this to WIP in Staging via automation Dec 2, 2020
@stale
Copy link

stale bot commented Mar 5, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 5, 2021
@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Mar 21, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

@SuperSandro2000 SuperSandro2000 merged commit 815dfb2 into NixOS:staging Apr 13, 2021
Staging automation moved this from WIP to Done Apr 13, 2021
Python batch upgrade automation moved this from To do to Done Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500 11.by: package-maintainer
Projects
Python batch upgrade
Done
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @jonringer @FRidh @SuperSandro2000