Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scas: init at 0.4.6 #94165

Merged
merged 2 commits into from Aug 1, 2020
Merged

scas: init at 0.4.6 #94165

merged 2 commits into from Aug 1, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Jul 29, 2020

Motivation for this change

Add scas Z80 assembler

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siraben siraben requested a review from sikmir July 30, 2020 03:23
@siraben
Copy link
Member Author

siraben commented Jul 31, 2020

Ready to merge.

@infinisil
Copy link
Member

Please rebase the PR such that it has an initial commit that adds you as a maintainer and a second commit that adds the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants