Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutterPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre #94092

Merged
merged 1 commit into from Jul 29, 2020
Merged

flutterPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre #94092

merged 1 commit into from Jul 29, 2020

Conversation

kolaente
Copy link
Member

Motivation for this change

Flutter update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kolaente kolaente mentioned this pull request Jul 28, 2020
Merged
10 tasks
@kolaente
Copy link
Member Author

Since this PR only updates beta and dev versions, it is probably not urgent. Especially since the stable version was updated recently.

@worldofpeace
Copy link
Contributor

@ofborg build flutterPackages.beta flutterPackages.dev

@worldofpeace
Copy link
Contributor

I think a more clear message to use for your commit would be:

flutterPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre

What is important is knowing which attribute has changed.

@kolaente
Copy link
Member Author

@worldofpeace I see. Should I change it and force-push again?

@worldofpeace
Copy link
Contributor

@worldofpeace I see. Should I change it and force-push again?

Yep.

@kolaente
Copy link
Member Author

@worldofpeace Done

@worldofpeace worldofpeace changed the title flutter beta (1.19.0-4.3.pre -> 1.20.0-7.2.pre), dev (1.20.0-3.0.pre -> 1.21.0-1.0.pre) update erPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre Jul 29, 2020
@worldofpeace worldofpeace changed the title erPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre flutterPackages.beta: 1.19.0-4.3.pre -> 1.20.0-7.2.pre, flutterPackages.dev: 1.20.0-3.0.pre -> 1.21.0-1.0.pre Jul 29, 2020
@worldofpeace worldofpeace merged commit 9b97ee7 into NixOS:master Jul 29, 2020
@worldofpeace
Copy link
Contributor

Thanks @kolaente, merged ✨

@kolaente kolaente deleted the update/flutter branch July 29, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kolaente @worldofpeace