Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-notes/rl-2009: amend bitcoind incompatibility #94166

Merged
merged 1 commit into from Aug 3, 2020
Merged

release-notes/rl-2009: amend bitcoind incompatibility #94166

merged 1 commit into from Aug 3, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented Jul 29, 2020 •
edited

Motivation for this change

Better documentation of the breaking change - i.e. how to properly migrate. Discussed in #93700

@emmanuelrosa

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101 1000101 requested a review from mmahut July 29, 2020 10:39
@1000101 1000101 mentioned this pull request Jul 30, 2020
Merged
10 tasks
@mmahut mmahut merged commit 4181ae2 into NixOS:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@dasj19 dasj19 dasj19 approved these changes

@emmanuelrosa emmanuelrosa emmanuelrosa approved these changes

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@1000101 @prusnak @dasj19 @emmanuelrosa @mmahut