Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minetime: 1.7.3 -> 1.8.4 #94138

Closed
wants to merge 1 commit into from
Closed

minetime: 1.7.3 -> 1.8.4 #94138

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 29, 2020

Motivation for this change

https://github.com/marcoancona/MineTime/releases/

(for various versions released between 1.7.3 and 1.8.4)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

I get a white window when running this

@dtzWill
Copy link
Member Author

dtzWill commented Sep 10, 2020

Thanks for testing, and sorry about that!

Should bump to 1.8.6 probably, too.

Tested this on master, and... can confirm? But it works in my tree, so not sure what's going on. So bisecting might work, but I am rather behind master so likely a mess :).

Will poke at this a bit when have some debugging bandwidth to throw at this, sorry for the borked update!

Closing until at least on track for working :).

@dtzWill dtzWill closed this Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @Lassulus