Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wine: 5.0.0 -> 5.0.1, wine{Unstable,Staging}: 5.12 -> 5.13 #94137

Closed
wants to merge 3 commits into from
Closed

wine: 5.0.0 -> 5.0.1, wine{Unstable,Staging}: 5.12 -> 5.13 #94137

wants to merge 3 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jul 29, 2020

Motivation for this change

https://www.winehq.org/announce/5.13
https://www.winehq.org/announce/5.0.1

https://www.phoronix.com/scan.php?page=news_item&px=Wine-5.13-Released

Also removes the disabling of xact_initial--
I'm not sure entirely what motivated us disabling it,
but optimistically re-enabling in response to finding this in the notes:

include: Correct a spelling error in the definition of IXACT3Engine_Initialize.

Feedback from anyone who knows more about it or can test is appreciated!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SFrijters
Copy link
Member

I don't know if there's any reason in particular to skip or not skip 5.13, but just FYI, Wine 5.14 has been released by now as well.

@risicle
Copy link
Contributor

risicle commented Sep 3, 2020

Is this outdated now?

@SFrijters
Copy link
Member

Superseded by #98999

@SFrijters SFrijters closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @SFrijters @risicle @ryantm