Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch: 1.5.1 -> 1.6.0 #94156

Merged
merged 1 commit into from Jul 31, 2020
Merged

python3Packages.pytorch: 1.5.1 -> 1.6.0 #94156

merged 1 commit into from Jul 31, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Jul 29, 2020 •
edited

Motivation for this change

Changelog:
https://github.com/pytorch/pytorch/releases/tag/v1.6.0

This release adds automatic mixed precision 🎉.

Tested CUDA build ✅

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from teh and thoughtpolice July 29, 2020 07:00
@danieldk danieldk marked this pull request as ready for review July 29, 2020 07:44
@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.pytorch python38Packages.pytorch

jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having some issues with the cuda versions, but the default CPU versions seem fine:

https://github.com/NixOS/nixpkgs/pull/94156
5 packages failed to build:
python37Packages.pyro-ppl python37Packages.pytorchWithCuda python37Packages.tensorboardx python38Packages.pyro-ppl python38Packages.tensorboardx

17 packages built:
python37Packages.ignite python37Packages.pytorch python37Packages.pytorch-metric-learning python37Packages.pywick python37Packages.skorch python37Packages.tensorly python37Packages.torchgpipe python37Packages.torchvision python38Packages.ignite python38Packages.pytorch python38Packages.pytorch-metric-learning python38Packages.pytorchWithCuda python38Packages.pywick python38Packages.skorch python38Packages.tensorly python38Packages.torchgpipe python38Packages.torchvision

gits to cuda failure: https://gist.github.com/jonringer/5bffe6be2bdbaa8d2b92688c1a3b528f

@danieldk
Copy link
Contributor Author

danieldk commented Jul 31, 2020 •
edited

Strange, builds here with CUDA and Python 3.7:

% nix-build -A python37Packages.pytorchWithCuda
[...]
Executing pythonImportsCheckPhase
Check whether the following modules can be imported: torch
/nix/store/pz7979y2w5qvy463ymplnsvqv01vf06c-python3.7-pytorch-1.6.0

@jonringer
Copy link
Contributor

I forgot to turn on my extra 256GB of swap space, the compiler could have OOM'd

@danieldk
Copy link
Contributor Author

I forgot to turn on my extra 256GB of swap space, the compiler could have OOM'd

The luxury of having too many cores? ;)

@jonringer
Copy link
Contributor

The luxury of having too many cores

Thanks AMD! :D

jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cpu package build fine, and the other failures aren't related to pytorch bump
I haven't done anything locally to enable cuda, so I'll take @danieldk 's word that it works under normal circumstances :)

@jonringer jonringer merged commit c67ba72 into NixOS:master Jul 31, 2020
@danieldk danieldk deleted the pytorch-1.6.0 branch July 31, 2020 17:59
@jonringer
Copy link
Contributor

more cpu and RAM for the Machine Learning throne:
Selection_040

@danieldk
Copy link
Contributor Author

danieldk commented Jul 31, 2020 •
edited

more cpu and RAM for the Machine Learning throne:

I'm envious ;). Though I am also enjoying AMD's resurgence with a 3700X at home.

@vbgl vbgl mentioned this pull request Aug 8, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@teh teh Awaiting requested review from teh

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danieldk @jonringer