qt5: Add the ability to optionally use NSS 3.44 #94101
Conversation
|
In what way is this optional? |
|
Oh, I should have worded that differently. What I meant was that the current nss would continue to be used unless it's set to a different version. In other words, this doesn't change the nss version for all Qt programs but rather makes it possible to change it for programs which fail with the current version. |
There was a problem hiding this comment.
I was able to use this to make qutebrowser work again 👍
I have only one question about the code: Did it previously run with nss 3.52 or with nss 3.44? I don't think we should downgrade further than needed to make it work.
And the commit message can be improved as already discussed above. I would suggest "qt5.qwebengine: use nss_3_44".
|
I'm ok with this solution as a quick workaround but it would be better to figure out why webengine can't handle nss >3.44. EDIT. Actually, it could simply be our Qt version is too old for this nss version, right? I should checkout @petabyteboy's PR for Qt 5.14 |
|
I think it might be a problem in nixpkgs, because QtWebEngine 5.15.0 with nss 3.54 doesn't work either, so it's not our Qt version that's too old. This version combination is advertised as a dependency here (tho that's not an official Qt page) and used by other distributions such as Arch Linux as well. Anyways this is kind of urgent because it will probably not be caught by tests so users of the nixos-unstable and nixos-unstable-small channels will receive a broken update. |
emmanuelrosa
force-pushed
the
qtwebengine-nss-fix
branch
from
5978686
to
69b939c
Compare
|
In the forced push I simply changed the commit message. |
|
#94188 seems to be the proper fix for this issue. |
|
I don't think this should be needed anymore. |
This is to address Qt programs which do not work with NSS 3.54.
See #94046
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)