Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teip: init at 1.2.1 #94094

Closed
wants to merge 1 commit into from
Closed

teip: init at 1.2.1 #94094

wants to merge 1 commit into from

Conversation

joefiorini
Copy link
Contributor

@joefiorini joefiorini commented Jul 28, 2020 •
edited

Motivation for this change

This module is a very useful, general purpose Unix tool that I think others would like to install via nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joefiorini joefiorini changed the title Add teip package teip: init at 1.2.1 Jul 28, 2020
sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
maintainers/maintainer-list.nix
@@ -3132,6 +3132,12 @@
githubId = 7385287;
name = "Lana Black";
};
greymd = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, adding yourself as a maintainer is preferred to be a separate commit.

Something like, maintainers: add greymd. Then apply the teip commit.

sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
pkgs/tools/misc/teip/default.nix
src = fetchFromGitHub {
owner = "greymd";
repo = "teip";
rev = "52b7a8b4a6cbf354a3620936cec7add257e2f483";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rev = "52b7a8b4a6cbf354a3620936cec7add257e2f483";
rev = "v${version}";

sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
pkgs/tools/misc/teip/default.nix

features = [ "oniguruma" ];

preFixup = ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
preFixup = ''
postInstall = ''

@stale
Copy link

stale bot commented Jan 25, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 25, 2021
doronbehar
doronbehar requested changes Aug 9, 2021
View reviewed changes
pkgs/tools/misc/teip/default.nix
homepage = "https://github.com/greymd/teip";
license = with licenses; [ mit ];
maintainers = with maintainers; [ greymd ];
platforms = platforms.x86_64;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this won't build on other platforms? Also, I think this should be x86_64-linux or perhaps in your case I'd set platforms.linux.

pkgs/tools/misc/teip/default.nix
Comment on lines +33 to +36
description = "Highly efficient \"Masking tape\" for standard input";
longDescription = ''
Select partial standard input and replace with the result of another command efficiently
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd put in description what you put in longDescription, "Masking tape" might be a confusing description for some people.

pkgs/tools/misc/teip/default.nix
Comment on lines +20 to +21
# Disabling tests because criterion build was hanging for me
# on Darwin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Disabling tests because criterion build was hanging for me
# on Darwin
# Disabling tests because criterion build was hanging for me
# on Darwin

@stale stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Aug 9, 2021
@doronbehar
Copy link
Contributor

@joefiorini please address the review comments.

SuperSandro2000
SuperSandro2000 reviewed Aug 9, 2021
View reviewed changes
pkgs/tools/misc/teip/default.nix
preFixup = ''
installManPage "$src/man/teip.1"

installShellCompletion --zsh $src/completion/zsh/_teip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash, fish?

@stale
Copy link

stale bot commented Apr 19, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Apr 19, 2022
@doronbehar doronbehar closed this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@doronbehar doronbehar doronbehar requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joefiorini @doronbehar @sikmir @SuperSandro2000