Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmenu: init at 4.3.1 #94095

Merged
merged 1 commit into from Aug 21, 2020
Merged

xmenu: init at 4.3.1 #94095

merged 1 commit into from Aug 21, 2020

Conversation

neonfuz
Copy link
Contributor

@neonfuz neonfuz commented Jul 28, 2020

Motivation for this change

Added package xmenu

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

alyssais
alyssais requested changes Aug 16, 2020
View reviewed changes
pkgs/applications/misc/xmenu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/xmenu/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/xmenu/default.nix Outdated Show resolved Hide resolved
@neonfuz
Copy link
Contributor Author

neonfuz commented Aug 16, 2020

Fixed the 3 requested changes.

@neonfuz neonfuz changed the title xmenu: added xmenu 2020-07-23 xmenu: added xmenu 4.3.1 Aug 17, 2020
@Lassulus Lassulus changed the title xmenu: added xmenu 4.3.1 xmenu: init at 4.3.1 Aug 21, 2020
@Lassulus Lassulus merged commit d1e6e1c into NixOS:master Aug 21, 2020
@phillbush
Copy link

Hello! xmenu developer here.
Just to announce that xmenu is now under the MIT License (the new version 4.3.2 has the new LICENSE file).

@neonfuz
Copy link
Contributor Author

neonfuz commented Sep 14, 2020

Just made a PR for the version bump, made the license change, thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neonfuz @phillbush @alyssais @Lassulus