Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xbattbar: init at 1.4.9 #94102

Merged
merged 1 commit into from Sep 8, 2020
Merged

xbattbar: init at 1.4.9 #94102

merged 1 commit into from Sep 8, 2020

Conversation

q3k
Copy link
Member

@q3k q3k commented Jul 28, 2020

Motivation for this change

Adds xbattbar - an oldschool but nice X11 battery status tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sikmir
sikmir reviewed Jul 29, 2020
View reviewed changes
pkgs/applications/misc/xbattbar/default.nix Outdated
meta = with stdenv.lib; {
description = "Display battery status in X11";
homepage = "https://salsa.debian.org/debian/xbattbar";
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

licenses.gpl2 is deprecated, consider using licenses.gpl2Plus or licenses.gpl2Only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Set to gpl2Plus as per upstream license header in xbattbar.c.

@Lassulus
Copy link
Member

Lassulus commented Sep 8, 2020

hmm, can't figure out how to use it. should it show up in the systray?

@q3k
Copy link
Member Author

q3k commented Sep 8, 2020

It should show up on the bottom of your screen as an ugly 3-pixel tall bar that shows the battery status, like so.

@Lassulus
Copy link
Member

Lassulus commented Sep 8, 2020

ah, indeed, its actually hard to see with all the clutter on my screen

@Lassulus Lassulus merged commit 8afc303 into NixOS:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@q3k @Lassulus @sikmir