Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tests to regex versions #452

Merged
merged 4 commits into from Jul 28, 2020
Merged

Convert tests to regex versions #452

merged 4 commits into from Jul 28, 2020

Conversation

grvvy
Copy link
Contributor

@grvvy grvvy commented Jul 27, 2020

No description provided.

@whitequark
Copy link
Member

Thanks. Can you remove the implementations of assertRaises and assertWarns too?

@grvvy
Copy link
Contributor Author

grvvy commented Jul 28, 2020 •
edited

Okay, there are a few calls left to the non-regex versions that don’t contain a msg argument. I’m guessing those should be changed over to regex versions as well then?

@whitequark
Copy link
Member

I mean these: https://github.com/nmigen/nmigen/blob/c75fa45fd80063ad5681f389fb038d6d98f4f0a0/nmigen/test/utils.py#L31-L46

@whitequark
Copy link
Member

I’m guessing those should be changed over to regex versions as well then?

Nope, they should work fine as-is, with no additional changes.

@whitequark whitequark merged commit 8117ef6 into amaranth-lang:master Jul 28, 2020
@whitequark
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grvvy @whitequark