Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.Dotenv: init at 0.002 #92605

Merged
merged 1 commit into from Aug 18, 2020
Merged

perlPackages.Dotenv: init at 0.002 #92605

merged 1 commit into from Aug 18, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Jul 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from stigtsp July 7, 2020 17:24
stigtsp
stigtsp approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@aanderse
Copy link
Member Author

aanderse commented Jul 7, 2020

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

@aanderse
Copy link
Member Author

aanderse commented Jul 7, 2020

No! Curse you perl 5.32!

@stigtsp
Copy link
Member

stigtsp commented Jul 7, 2020

No! Curse you perl 5.32!

Pod::Parser was removed from perl 5.32, causing Pod::Coverage to fail.

@aanderse
Copy link
Member Author

aanderse commented Jul 9, 2020

@stigtsp I manage systems for perl developers and maintain infrastructure, but don`t (generally) write much/any myself. Any hints on where to go from here?

@stigtsp
Copy link
Member

stigtsp commented Jul 9, 2020

@stigtsp I manage systems for perl developers and maintain infrastructure, but don`t (generally) write much/any myself. Any hints on where to go from here?

Adding PodParser as a propagatedBuildInput for PodCoverage seems like the way to go.

When we bump the default perl to 5.32, Pod::Parser will dissappear from it's Module::CoreList. And misc checks in nix-generate-from-cpan (and likely cpan2nix) will start including it as a dependency for new and updated packages.

@aanderse
Copy link
Member Author

aanderse commented Jul 9, 2020

@stigtsp thanks for the explanation. Is that a PR you would be willing to file? If I had to fill out the "motivation" section on that PR I would have to say "Because @stigtsp said so, and it kinda makes sense to me..." 😄

@stigtsp
Copy link
Member

stigtsp commented Jul 9, 2020

@stigtsp thanks for the explanation. Is that a PR you would be willing to file?

No prob - I'll have a look to see if there are other modules that need to be updated due to this change in 5.32.

@stigtsp
Copy link
Member

stigtsp commented Jul 15, 2020 •
edited

The Pod::Parser issue is mentioned in the perl 5.32.0 bump #93036 and fixes are added in #93187

@aanderse
Copy link
Member Author

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

@stigtsp
Copy link
Member

stigtsp commented Jul 16, 2020

[..] build perlPackages.Dotenv perldevelPackages.Dotenv

Should mention that the PRs are against staging, and not merged yet. :)

@stigtsp
Copy link
Member

stigtsp commented Aug 16, 2020

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

@stigtsp
Copy link
Member

stigtsp commented Aug 16, 2020

@aanderse As #93187 has made it's way to master, this now builds. :)

@aanderse
Copy link
Member Author

@GrahamcOfBorg build perlPackages.Dotenv perldevelPackages.Dotenv

@aanderse aanderse merged commit 945e4a6 into NixOS:master Aug 18, 2020
@aanderse aanderse deleted the perl-packages/dotenv branch August 18, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aanderse @stigtsp