Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.YAMLSyck: fix darwin build #92613

Merged
merged 1 commit into from Jul 7, 2020
Merged

perlPackages.YAMLSyck: fix darwin build #92613

merged 1 commit into from Jul 7, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jul 7, 2020

Fixes build for Darwin by adding export LD=$CC to the perlPreHook.

It's probably also needed for i686, since this is commonly found elsewhere in perlPackages, but don't have an i686 available so feels wrong to include it without testing.

This fix is required for quite a few perlPackages that fail to build on darwin. Is it doable to set LD=$CC in buildPerlPackage as a default for darwin (and perhaps i686)?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from aanderse and volth July 7, 2020 17:59
@aanderse
Copy link
Member

aanderse commented Jul 7, 2020

@GrahamcOfBorg build perlPackages.YAMLSyck perldevelPackages.YAMLSyck

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 7, 2020
@aanderse
Copy link
Member

aanderse commented Jul 7, 2020

Thanks @stigtsp 🎉

@aanderse aanderse merged commit 4a9dac0 into NixOS:master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse