Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rustup): (add zlib to rpath in rustup libraries) #92615

Merged
merged 1 commit into from Jul 7, 2020
Merged

(rustup): (add zlib to rpath in rustup libraries) #92615

merged 1 commit into from Jul 7, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 7, 2020

Motivation for this change

Stable backport of #91327

I've check locally that:

  • rustup builds and works
  • nightly rust downloaded by rustup works ()
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@witchof0x20 @matklad
(rustup): (add zlib to rpath in rustup libraries)
7fb99d6 
(Rust now has a dynamic library dependence on zlib. (see rust-lang/rust#72696))
@ofborg ofborg bot requested a review from Mic92 July 7, 2020 18:37
@Mic92 Mic92 merged commit e0e2e4f into NixOS:release-20.03 Jul 7, 2020
@matklad matklad deleted the backport branch July 8, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matklad @Mic92 @witchof0x20