Skip to content

nixos/xpadneo: init at 0.8.1 #92622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2020
Merged

nixos/xpadneo: init at 0.8.1 #92622

merged 1 commit into from
Jul 23, 2020
+69 −0

Conversation

kira-bruneau
Copy link
Contributor

Motivation for this change

I just got an Xbox One controller and I wasn't satisfied with the xpad
driver that ships with the Linux kernel

xpadneo supports more features and fixes problems with
incorrect button mappings

https://atar-axis.github.io/xpadneo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    No binary files, tested through use of Xbox One controller
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jul 7, 2020
@kira-bruneau
Copy link
Contributor Author

There are plans to upstream this driver to the kernel (atar-axis/xpadneo#44), but I think it will still be useful to package this until then.

@kira-bruneau kira-bruneau changed the title nixos/xpadneo: init at 0.7.5 nixos/xpadneo: init at 0.7.6 Jul 11, 2020
@kira-bruneau kira-bruneau changed the title nixos/xpadneo: init at 0.7.6 nixos/xpadneo: init at 0.8 Jul 11, 2020
@kira-bruneau
Copy link
Contributor Author

Formatted with nixpkgs-fmt

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Jul 22, 2020
@cole-h
Copy link
Member

cole-h commented Jul 22, 2020

@ofborg eval

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jul 22, 2020
@kira-bruneau
nixos/xpadneo: init at 0.8.1
db96d88 
I just got an Xbox One controller and I wasn't satisfied with the xpad
driver that ships with the Linux kernel

xpadneo supports more features and fixes problems with
incorrect button mappings

https://atar-axis.github.io/xpadneo
@kira-bruneau kira-bruneau changed the title nixos/xpadneo: init at 0.8 nixos/xpadneo: init at 0.8.1 Jul 23, 2020
worldofpeace
worldofpeace approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but everything looks good.

@worldofpeace worldofpeace merged commit 78d9dad into NixOS:master Jul 23, 2020
@kira-bruneau
Copy link
Contributor Author

@worldofpeace Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kira-bruneau @cole-h @worldofpeace