Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkgmap: 4432 -> 4565 #92666

Merged
merged 2 commits into from Oct 8, 2020
Merged

mkgmap: 4432 -> 4565 #92666

merged 2 commits into from Oct 8, 2020

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Jul 8, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh ./result
/nix/store/0rk5280sd8ayj3jv2x904iqv24jhpvkk-mkgmap-4432	 221.0M
$ nix path-info -Sh ./result
/nix/store/gvzyalifpaybidmjr06qap6hpmni4rcl-mkgmap-4565	 220.0M
$ nix path-info -Sh ./result
/nix/store/v3gdks6bff4f9q8gx7dr11ri1z9yij9f-splitter-597	 218.3M

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/225

@sikmir sikmir changed the title mkgmap: 4432 -> 4555 mkgmap: 4432 -> 4565 Jul 25, 2020
risicle
risicle approved these changes Sep 5, 2020
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM, macos 10.14

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/243

@AndersonTorres AndersonTorres merged commit 8bcfed0 into NixOS:master Oct 8, 2020
@sikmir sikmir deleted the mkgmap branch October 8, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sikmir @nixos-discourse @risicle @AndersonTorres