Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: add xorg.xkbcomp #92667

Merged
merged 1 commit into from Jul 8, 2020
Merged

lutris: add xorg.xkbcomp #92667

merged 1 commit into from Jul 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 8, 2020 •
edited

Motivation for this change

follow-up to #92629
xorg.xkbcomp is also needed.

Traceback (most recent call last):
  File "/nix/store/v1mzyrrnmm9xm7mhqps6pdxdyvkgb154-lutris-original-0.5.6/lib/python3.8/site-packages/lutris/exceptions.py", line 36, in wrapper
    return function(*args, **kwargs)
  File "/nix/store/v1mzyrrnmm9xm7mhqps6pdxdyvkgb154-lutris-original-0.5.6/lib/python3.8/site-packages/lutris/game.py", line 430, in configure_game
    xkbcomp = subprocess.Popen(xkbcomp_command, stdin=subprocess.PIPE)
  File "/nix/store/f87w21b91cws0wbsvyfn5vnlyv491czi-python3-3.8.3/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/f87w21b91cws0wbsvyfn5vnlyv491czi-python3-3.8.3/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'xkbcomp'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
lutris: add xorg.xkbcomp
df99f19 
```
Traceback (most recent call last):
  File "/nix/store/v1mzyrrnmm9xm7mhqps6pdxdyvkgb154-lutris-original-0.5.6/lib/python3.8/site-packages/lutris/exceptions.py", line 36, in wrapper
    return function(*args, **kwargs)
  File "/nix/store/v1mzyrrnmm9xm7mhqps6pdxdyvkgb154-lutris-original-0.5.6/lib/python3.8/site-packages/lutris/game.py", line 430, in configure_game
    xkbcomp = subprocess.Popen(xkbcomp_command, stdin=subprocess.PIPE)
  File "/nix/store/f87w21b91cws0wbsvyfn5vnlyv491czi-python3-3.8.3/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/nix/store/f87w21b91cws0wbsvyfn5vnlyv491czi-python3-3.8.3/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'xkbcomp'
```
@ofborg ofborg bot requested a review from Chiiruno July 8, 2020 00:49
@worldofpeace worldofpeace merged commit 8632843 into NixOS:master Jul 8, 2020
@jonringer jonringer deleted the fix-lutris-us branch July 8, 2020 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace