Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: fix for us keyboard layouts #92629

Merged
merged 1 commit into from Jul 8, 2020
Merged

lutris: fix for us keyboard layouts #92629

merged 1 commit into from Jul 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

may need to call setxkbmap

https://github.com/lutris/lutris/blob/bb7565f14f748eea95fc3c3b4efd8e49099a832d/lutris/game.py#L635

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Chiiruno July 7, 2020 20:05
@worldofpeace
Copy link
Contributor

Feel free to merge after the requested change is supplied.

@jonringer
Copy link
Contributor Author

I'll merge after ofborg checks finish

@jonringer jonringer merged commit dc16bda into NixOS:master Jul 8, 2020
@jonringer jonringer deleted the fix-lutris-us branch July 8, 2020 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@Chiiruno Chiiruno Awaiting requested review from Chiiruno

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @worldofpeace