update.nix: Allow passing overlays #92628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we relied on NIX_PATH for passing overlays but with flakes, we should pass them explicitly.
jtojnar
added a commit
to jtojnar/nixfiles
that referenced
this pull request
Jul 10, 2020
Previously, I had to update expressions using commands like env NIX_PATH="$NIX_PATH:nixpkgs-overlays=$HOME/Projects/nixfiles/common/overlays" nix-shell maintainers/scripts/update.nix --arg include-overlays true --argstr path selfoss but that was too long-winded and relied on nixpkgs impurely taking the overlays from NIX_PATH. Let's just add a script that transparently and explicitly passes the pkgs overlay to nixpkgs, so that we can run update selfoss Depends on NixOS/nixpkgs#92628
|
The change is backwards compatible and the option is internal (undocumented) so we can still change it in the future if we find a better design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we relied on
NIX_PATHfor passing overlays but with flakes, we should pass them explicitly.