Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plantuml-server: init at 1.2020.14 #92582

Merged
merged 2 commits into from Dec 16, 2020
Merged

plantuml-server: init at 1.2020.14 #92582

merged 2 commits into from Dec 16, 2020

Conversation

truh
Copy link
Member

@truh truh commented Jul 7, 2020 •
edited

Motivation for this change

Add PlantUML server package and service module. https://plantuml.com/server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@truh truh force-pushed the plantuml-server-squash branch 2 times, most recently from 8d80465 to 67936ee Compare July 8, 2020 17:43
@truh truh changed the title plantuml-server: init at 1.2020.15 plantuml-server: init at 1.2020.14 Jul 8, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 92582 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
1 package built:
  • plantuml-server

doronbehar
doronbehar approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Tested with services.plantuml-server.enable = true; and it seems functional. Thanks for the contribution :).

@doronbehar doronbehar merged commit 749c9f1 into NixOS:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@truh @SuperSandro2000 @nh2 @sikmir @doronbehar