Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: Noto Mono -> Noto Sans Mono #92593

Merged
merged 1 commit into from Jul 7, 2020
Merged

nixos/plasma5: Noto Mono -> Noto Sans Mono #92593

merged 1 commit into from Jul 7, 2020

Conversation

samuelgrf
Copy link
Member

Motivation for this change

The font has been renamed. See notofonts/noto-fonts#1029

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 8124688 into NixOS:master Jul 7, 2020
@worldofpeace
Copy link
Contributor

Backport needed? I would assume the default font would just not work.

@samuelgrf
Copy link
Member Author

Fontconfig uses a different font, it goes through available fonts alphabetically, on my machine it uses DejaVu instead of Noto. Should I open a backport pr for this?

@worldofpeace
Copy link
Contributor

Fontconfig uses a different font, it goes through available fonts alphabetically, on my machine it uses DejaVu instead of Noto. Should I open a backport pr for this?

I think so. But, would fontconfig for example suddenly change which font is used on the endusers system? Like with this change, users of the plasma5 module will suddenly have Noto Sans Mono instead of the incorrect default of DejaVu? If that's so, then I'd say it wouldn't be suitable for backport.

@samuelgrf
Copy link
Member Author

Yes it would, but the new defaults are only applied after restarting plasma.
It also shouldn't really cause any problems, since Noto Sans Mono is only meant as a fallback for characters that are unsupported by Hack, which comes first in 'fonts.fontconfig.defaultFonts.monospace', so this wouldn't make a difference for most text.

@worldofpeace
Copy link
Contributor

Yes it would, but the new defaults are only applied after restarting plasma.
It also shouldn't really cause any problems, since Noto Sans Mono is only meant as a fallback for characters that are unsupported by Hack, which comes first in 'fonts.fontconfig.defaultFonts.monospace', so this wouldn't make a difference for most text.

Sounds good to me 👍

@samuelgrf samuelgrf mentioned this pull request Jul 7, 2020
Merged
10 tasks
@samuelgrf samuelgrf deleted the fix/plasma5-noto-rename branch March 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelgrf @worldofpeace