Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/fontconfig: fix emojis with penultimate enabled #92571

Closed
wants to merge 1 commit into from
Closed

nixos/fontconfig: fix emojis with penultimate enabled #92571

wants to merge 1 commit into from

Conversation

samuelgrf
Copy link
Member

@samuelgrf samuelgrf commented Jul 7, 2020 •
edited

Motivation for this change

This fixes the 'fonts.fontconfig.defaultFonts.emoji' option not being applied when penultimate is enabled ('fonts.fontconfig.penultimate.enable' set to true).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@samuelgrf
nixos/fontconfig: fix emojis with penultimate enabled
ca95f3a 
This fixes the 'fonts.fontconfig.defaultFonts.emoji' option not
being applied when penultimate is enabled.
@worldofpeace
Copy link
Contributor

@samuelgrf The fontconfig configuration used for penultimate does not contain an emoji type. That is why the default fontconfig configuration is used default in nixos. Penultimate is likely to be removed soon as well.

@samuelgrf
Copy link
Member Author

Makes sense, going to close this then.

@samuelgrf samuelgrf closed this Jul 7, 2020
This was referenced Aug 17, 2020
Closed
Merged
@flokli
Copy link
Contributor

flokli commented Aug 17, 2020

I opened #95681 removing fontconfig-pentultimate.

@samuelgrf samuelgrf deleted the fix/fontconfig-penultimate-emoji branch March 5, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samuelgrf @worldofpeace @flokli