Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.xmlschema: 1.1.0 -> 1.2.2 #92649

Merged
merged 1 commit into from Jul 9, 2020
Merged

python3Packages.xmlschema: 1.1.0 -> 1.2.2 #92649

merged 1 commit into from Jul 9, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
https://github.com/NixOS/nixpkgs/pull/92649
6 packages built:
python37Packages.fints python37Packages.sepaxml python37Packages.xmlschema python38Packages.fints python38Packages.sepaxml python38Packages.xmlschema

@jonringer jonringer requested a review from FRidh as a code owner July 7, 2020 21:44
drewrisinger
drewrisinger suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PyPi page states that only py3.5+ are supported.

Otherwise, LGTM

  • Diff LGTM (minus disable)
  • Commits LGTM
  • Builds via nix-review
  • self-tested
https://github.com/NixOS/nixpkgs/pull/92649
6 packages built:
python37Packages.fints python37Packages.sepaxml python37Packages.xmlschema python38Packages.fints python38Packages.sepaxml python38Packages.xmlschema

pkgs/development/python-modules/xmlschema/default.nix Show resolved Hide resolved
pkgs/development/python-modules/xmlschema/default.nix Show resolved Hide resolved
@jonringer jonringer merged commit 3e42013 into NixOS:master Jul 9, 2020
@jonringer jonringer deleted the bump-xmlschema branch July 9, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger requested changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @drewrisinger