pytest-sugar: 0.9.3 -> 0.9.4 #92573
Merged
pytest-sugar: 0.9.3 -> 0.9.4 #92573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks good to me, I'd just prefer to have two commits instead of six: upgrade version and using pytestCheckHook. |
dotlambda
force-pushed
the
pytest-sugar-0.9.4
branch
from
9bd4ead
to
3991a7a
Compare
jonringer
reviewed
Jul 7, 2020
There was a problem hiding this comment.
not sure how many are failing on master, but from a quick glance, i would say at least half
https://github.com/NixOS/nixpkgs/pull/92573
65 packages failed to build:
mlflow-server python27Packages.cufflinks python27Packages.pytrends python27Packages.statsmodels python27Packages.trackpy python27Packages.vega python37Packages.altair python37Packages.caffe python37Packages.cnvkit python37Packages.dask-image python37Packages.dask-xgboost python37Packages.datashader python37Packages.flower python37Packages.google_cloud_automl python37Packages.heudiconv python37Packages.imbalanced-learn python37Packages.mlflow python37Packages.nipype python37Packages.optuna python37Packages.phik python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ignis python37Packages.rl-coach python37Packages.rpy2 python37Packages.runway-python python37Packages.streamz python37Packages.sumo python37Packages.sunpy python37Packages.trackpy python37Packages.vega python37Packages.xgboost python38Packages.altair python38Packages.caffe python38Packages.cnvkit python38Packages.dask-image python38Packages.dask-jobqueue python38Packages.dask-ml python38Packages.dask-mpi python38Packages.dask-xgboost python38Packages.datashader python38Packages.distributed python38Packages.flower python38Packages.google_cloud_automl python38Packages.imbalanced-learn python38Packages.mlflow python38Packages.nipype python38Packages.phik python38Packages.qasm2image python38Packages.qiskit python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ignis python38Packages.rpy2 python38Packages.runway-python python38Packages.streamz python38Packages.stumpy python38Packages.sumo python38Packages.sunpy python38Packages.trackpy python38Packages.vega python38Packages.xgboost streamlit
228 packages built:
apache-airflow buildbot buildbot-full buildbot-ui cq-editor csvs-to-sqlite cura octoprint poretools python27Packages.amqp python27Packages.awkward python27Packages.bkcharts python27Packages.cfn-lint python27Packages.drms python27Packages.duckdb python27Packages.flammkuchen python27Packages.imbalanced-learn python27Packages.junit-xml python27Packages.mapsplotlib python27Packages.moto python27Packages.pandas python27Packages.pytest-sugar python27Packages.seaborn python27Packages.uproot python27Packages.uproot-methods python27Packages.vega_datasets python27Packages.vidstab python27Packages.wordcloud python37Packages.Quandl python37Packages.acoustics python37Packages.amqp python37Packages.aplpy python37Packages.apptools python37Packages.arviz python37Packages.atomman python37Packages.awkward python37Packages.batchgenerators python37Packages.bkcharts python37Packages.buildbot python37Packages.buildbot-full python37Packages.buildbot-ui python37Packages.celery python37Packages.cfn-lint python37Packages.cirq python37Packages.colorcet python37Packages.csvs-to-sqlite python37Packages.cufflinks python37Packages.dask python37Packages.dask-glm python37Packages.dask-jobqueue python37Packages.dask-ml python37Packages.dask-mpi python37Packages.dftfit python37Packages.distributed python37Packages.django-raster python37Packages.djmail python37Packages.drms python37Packages.duckdb python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.envisage python37Packages.fastparquet python37Packages.flammkuchen python37Packages.geopandas python37Packages.glymur python37Packages.google_cloud_bigquery python37Packages.google_cloud_monitoring python37Packages.graspy python37Packages.hickle python37Packages.holoviews python37Packages.hvplot python37Packages.ibis-framework python37Packages.ics python37Packages.image-match python37Packages.imagecorruptions python37Packages.imgaug python37Packages.intake python37Packages.ipydatawidgets python37Packages.junit-xml python37Packages.kombu python37Packages.lammps-cython python37Packages.mask-rcnn python37Packages.mayavi python37Packages.mesa python37Packages.moto python37Packages.nbsmoke python37Packages.nilearn python37Packages.osmnx python37Packages.osmpythontools python37Packages.pandas python37Packages.partd python37Packages.pims python37Packages.pvlib python37Packages.pyarrow python37Packages.pybids python37Packages.pyfftw python37Packages.pymatgen python37Packages.pymatgen-lammps python37Packages.pymc3 python37Packages.pytest-sugar python37Packages.pytrends python37Packages.pywick python37Packages.qiskit-ibmq-provider python37Packages.qiskit-terra python37Packages.sanic python37Packages.sanic-auth python37Packages.scikit-bio python37Packages.scikitimage python37Packages.seaborn python37Packages.sentry-sdk python37Packages.skorch python37Packages.sparse python37Packages.spectral-cube python37Packages.spyder-kernels_0_5 python37Packages.spyder_3 python37Packages.statsmodels python37Packages.stumpy python37Packages.stytra python37Packages.tablib python37Packages.tensorboardx python37Packages.tensorly python37Packages.traittypes python37Packages.uproot python37Packages.uproot-methods python37Packages.vega_datasets python37Packages.vidstab python37Packages.wordcloud python37Packages.wrf-python python37Packages.xarray python38Packages.Quandl python38Packages.acoustics python38Packages.amqp python38Packages.aplpy python38Packages.apptools python38Packages.atomman python38Packages.awkward python38Packages.batchgenerators python38Packages.bkcharts python38Packages.celery python38Packages.cfn-lint python38Packages.cirq python38Packages.colorcet python38Packages.cufflinks python38Packages.dask python38Packages.dask-glm python38Packages.dftfit python38Packages.django-raster python38Packages.djmail python38Packages.drms python38Packages.duckdb python38Packages.entrance python38Packages.entrance-with-router-features python38Packages.envisage python38Packages.fastparquet python38Packages.flammkuchen python38Packages.geopandas python38Packages.glymur python38Packages.google_cloud_bigquery python38Packages.google_cloud_monitoring python38Packages.graspy python38Packages.hickle python38Packages.holoviews python38Packages.hvplot python38Packages.ics python38Packages.image-match python38Packages.imagecorruptions python38Packages.imgaug python38Packages.intake python38Packages.ipydatawidgets python38Packages.junit-xml python38Packages.kombu python38Packages.lammps-cython python38Packages.mayavi python38Packages.mesa python38Packages.moto python38Packages.nbsmoke python38Packages.nilearn python38Packages.osmnx python38Packages.osmpythontools python38Packages.pandas python38Packages.partd python38Packages.pims python38Packages.pvlib python38Packages.pyarrow python38Packages.pybids python38Packages.pyfftw python38Packages.pymatgen python38Packages.pymatgen-lammps python38Packages.pytest-sugar python38Packages.pytrends python38Packages.pywick python38Packages.qiskit-ibmq-provider python38Packages.qiskit-terra python38Packages.sanic python38Packages.sanic-auth python38Packages.scikit-bio python38Packages.scikitimage python38Packages.seaborn python38Packages.sentry-sdk python38Packages.skorch python38Packages.sparse python38Packages.spectral-cube python38Packages.spyder-kernels_0_5 python38Packages.spyder_3 python38Packages.statsmodels python38Packages.stytra python38Packages.tablib python38Packages.tensorboardx python38Packages.tensorly python38Packages.traittypes python38Packages.uproot python38Packages.uproot-methods python38Packages.vega_datasets python38Packages.vidstab python38Packages.wordcloud python38Packages.wrf-python python38Packages.xarray sourcehut.buildsrht sourcehut.dispatchsrht sourcehut.gitsrht sourcehut.hgsrht sourcehut.listssrht sourcehut.mansrht sourcehut.metasrht sourcehut.pastesrht sourcehut.todosrht tebreak visidata
I disagree for the sake of potentially needing to cherry pick to a release branch. Having 2 commits would carry over more changes than potentially necessary |
|
looking through th elogs, the failures seem to be related to missing dependencies or bad version bounds. Not related to the changes in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update package and remove some useless checkInputs.
@FRidh I wasn't able to get
pytestCheckHookrunning for wordcloud.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)