Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dhcpd: make authoritative mode optional #92638

Merged
merged 1 commit into from Jul 25, 2020
Merged

nixos/dhcpd: make authoritative mode optional #92638

merged 1 commit into from Jul 25, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented Jul 7, 2020

Motivation for this change

I was suprised to find that the dhcpd4 module hard-codes authoritative mode at the top of the config file. Its reasonable default, but there are circumstances where it may be wise to resuse a configuration for multiple DHCP servers within a subnet, but with only a single authoritative server.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ehmry
nixos/dhcpd: make authoritative mode optional
bc2c703 
There are circumstances where running secondary DHCP servers in
non-authoritative mode is advantageous. Retain the previous
authoritative behavior as a default.
@ehmry ehmry merged commit a878038 into NixOS:master Jul 25, 2020
@ehmry ehmry deleted the dhcp-not-authoritative branch July 25, 2020 14:33
@mweinelt mweinelt mentioned this pull request Jul 26, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ehmry