Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin-abc: 0.21.5 -> 0.21.10 #92640

Merged
merged 1 commit into from Jul 8, 2020
Merged

bitcoin-abc: 0.21.5 -> 0.21.10 #92640

merged 1 commit into from Jul 8, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

noticed it was out of date in r-ryantm logs

switch from autotools to cmake, as it was deprecated upstream

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from mmahut as a code owner July 7, 2020 20:50
@jonringer jonringer requested a review from Lassulus July 7, 2020 20:50
@Lassulus
Copy link
Member

Lassulus commented Jul 8, 2020

seems like the variant without gui bitcoind-abc doesn't build anymore:

builder for '/nix/store/72a1vsxa4x1nrj9r7phxhl3ykx3l3xay-bitcoind-abc-0.21.10.drv' failed with exit code 1; last 10 log lines:
      qt5-config.cmake
  
    Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
    to a directory containing one of the above files.  If "Qt5" provides a
    separate development package or SDK, be sure it has been installed.
  
  
  -- Configuring incomplete, errors occurred!
  See also "/build/source/build/CMakeFiles/CMakeOutput.log".
  See also "/build/source/build/CMakeFiles/CMakeError.log".

@jonringer
Copy link
Contributor Author

@Lassulus fixed

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build bitcoind-abc

@Lassulus Lassulus merged commit 16f45c1 into NixOS:master Jul 8, 2020
@jonringer jonringer deleted the bump-bitcoin-abc branch July 8, 2020 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @Lassulus