Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assh: 2.7.0 -> 2.10.0, use buildGoModule #92642

Merged
merged 1 commit into from Jul 7, 2020
Merged

assh: 2.7.0 -> 2.10.0, use buildGoModule #92642

merged 1 commit into from Jul 7, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

noticed it was out of date in logs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from zzamboni July 7, 2020 20:57
@zzamboni
Copy link
Contributor

zzamboni commented Jul 7, 2020

@jonringer thanks, but I'm not using Nix anymore, so I am not able to review nor test.

@ofborg ofborg bot requested a review from kalbasit July 7, 2020 21:16
@jonringer
Copy link
Contributor Author

the program gets ran as part of the installCheckPhase, I think this is fine to merge

@jonringer jonringer merged commit 4d12536 into NixOS:master Jul 7, 2020
@jonringer jonringer deleted the bump-assh branch July 7, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzamboni zzamboni Awaiting requested review from zzamboni

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @zzamboni