Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.lxml: 4.5.0 -> 4.5.2 #92648

Merged
merged 1 commit into from Jul 30, 2020
Merged

python3Packages.lxml: 4.5.0 -> 4.5.2 #92648

merged 1 commit into from Jul 30, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jul 7, 2020 •
edited

Motivation for this change

noticed it was out of date

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner July 7, 2020 21:35
@jonringer jonringer changed the base branch from master to staging July 7, 2020 22:08
@jonringer
Copy link
Contributor Author

sorry for spam, had to change base branch

@jonringer jonringer added this to WIP in Staging via automation Jul 7, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg eval

@ofborg ofborg bot removed the 6.topic: golang label Jul 8, 2020
@veehaitch
Copy link
Member

Meanwhile, 4.5.2 was realeased: https://github.com/lxml/lxml/tree/lxml-4.5.2

@jonringer jonringer changed the title python3Packages.lxml: 4.5.0 -> 4.5.1 python3Packages.lxml: 4.5.0 -> 4.5.2 Jul 13, 2020
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pandas
@GrahamcOfBorg build python37Packages.pandas
@GrahamcOfBorg build pythonPackages.pandas

@jonringer
Copy link
Contributor Author

@FRidh would you know why this fails? https://github.com/NixOS/nixpkgs/pull/92648/checks?check_run_id=866317340

related code:

  # Remove .pytest_cache when using py.test in a Nix build
  setupHook = writeText "pytest-hook" ''
    pytestcachePhase() {
        find $out -name .pytest_cache -type d -exec rm -rf {} +
    }
    preDistPhases+=" pytestcachePhase"
  '';

fails on non linux-x86-64

@FRidh FRidh merged commit 49322fa into NixOS:staging Jul 30, 2020
Staging automation moved this from WIP to Done Jul 30, 2020
@jonringer jonringer deleted the bump-lxml branch July 31, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@andir andir Awaiting requested review from andir

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @veehaitch @FRidh