Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin isolation: add various navigation WPTs #24498

Merged
merged 1 commit into from Jul 9, 2020

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jul 7, 2020

This adds web platform tests covering various navigation scenarios for
origin isolation. The intention is to cover at least all the non-popup
navigation cases in isolated_origin_browsertest.cc. We also want to
approach the same coverage for navigation as we have for two-iframe
scenarios (i.e. the various parent-child1-child2 tests), but we avoid
doubling the size of the test suite by focusing on the more important
or tricky scenarios instead of just copying all of those.

Bug: 1042415
Change-Id: Ifb937f183af2610f348e4fea036d96aa0504ddab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285258
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786945}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

This adds web platform tests covering various navigation scenarios for
origin isolation. The intention is to cover at least all the non-popup
navigation cases in isolated_origin_browsertest.cc. We also want to
approach the same coverage for navigation as we have for two-iframe
scenarios (i.e. the various parent-child1-child2 tests), but we avoid
doubling the size of the test suite by focusing on the more important
or tricky scenarios instead of just copying all of those.

Bug: 1042415
Change-Id: Ifb937f183af2610f348e4fea036d96aa0504ddab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285258
Commit-Queue: Domenic Denicola <domenic@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786945}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants